CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260720T224743794Z-4cd3c742-3a3 #72
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "change_forgejo_end_to_end"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.
Run marker: codesnuffler-forgejo-live-20260720T224743794Z-4cd3c742-3a3.
Run started at: 2026-07-20T22:47:43.794Z.
Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This stable two-commit AI Harness range is expected to produce actionable findings.
CodeSnuffler Review Findings
Findings
1. Dev shell auth sessions ignore selected non-primary instance
app/dev_shell.py:320Details for this finding were posted as an inline review comment on the changed line.
Open finding in CodeSnuffler
Fix via CodeSnuffler
2. Auth container env no longer matches documented contract
container_image_controller/api.py:971-973Details for this finding were posted as an inline review comment on the changed line.
Open finding in CodeSnuffler
Fix via CodeSnuffler
@ -316,3 +318,3 @@async def dev_shell_websocket(websocket: WebSocket) -> None:command_id = websocket.query_params.get("command", "bash")persona_id = websocket.query_params.get("persona_id")instance_id = websocket.query_params.get("instance_id")CodeSnuffler finding: Dev shell auth sessions ignore selected non-primary instance
Severity: Medium Category: Correctness
The websocket route now only reads
instance_id, but the existing frontend dev-shell terminal still sendspersona_id. Any login terminal opened for a non-primary AI tool instance will arrive here withinstance_id == Noneand_proxy_runner_auth_sessionwill default toprimary, writing auth into the wrong instance storage.Commit: Open commit
d8a3fc420b05Open finding in CodeSnuffler
Fix via CodeSnuffler
Suggested fix: Update the dev-shell client/frontend to send
instance_idand add coverage for a non-primary login command preserving that value end to end.@ -945,3 +970,2 @@env = [f"TOOL_ID={profile.tool_id}",f"TOOL_PERSONA_ID={session.persona_id}",f"DRIVER_ID={profile.tool_id}",CodeSnuffler finding: Auth container env no longer matches documented contract
Severity: Medium Category: Correctness
The controller now emits
DRIVER_IDand removedTOOL_ID, while the repository's runtime contract documentsTOOL_ID,PLUGIN_ID,PLUGIN_INSTANCE_ID, andAI_TOOL_DRIVER_ID. Auth adapter commands or shell flows written against that contract will not receive the documented driver/tool variables.Commit: Open commit
d8a3fc420b05Open finding in CodeSnuffler
Fix via CodeSnuffler
Suggested fix: Make the emitted env names match the current contract, or update the contract and all consumers/tests in the same change. Avoid leaving both old and new names unless compatibility is explicitly requested.
Pull request closed