jason-admin/CodeSnuffler-FJ
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260627T122625590Z-b08611ae-5f9 #39

Closed
jason-admin wants to merge 2 commits from change_forgejo_review_findings_v1 into base_forgejo_review_findings_v1
pull from: change_forgejo_review_findings_v1
merge into: jason-admin:base_forgejo_review_findings_v1
Conversation 1 Commits 2 Files changed 24 +408 -215
jason-admin commented 2026-06-27 12:41:26 +00:00
Owner
Copy link

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.

Run marker: codesnuffler-forgejo-live-20260627T122625590Z-b08611ae-5f9.
Run started at: 2026-06-27T12:26:25.590Z.

Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings.

Webhook refresh marker: codesnuffler-forgejo-live-20260627T122625590Z-b08611ae-5f9.

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff. Run marker: codesnuffler-forgejo-live-20260627T122625590Z-b08611ae-5f9. Run started at: 2026-06-27T12:26:25.590Z. Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1. This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings. Webhook refresh marker: codesnuffler-forgejo-live-20260627T122625590Z-b08611ae-5f9.
This completes Step 12 of the AI harness plugin-instance plan by replacing the tool auth container session contract's persona field with explicit plugin instance identity. Controller request and response schemas, auth image refs, build payloads, dev-shell websocket forwarding, Docker labels, container env, and shared probe metadata now carry plugin_id, instance_id, and driver_id.

The controller now rejects mismatched plugin or driver identity, uses PLUGIN_INSTANCE_ID instead of TOOL_PERSONA_ID in auth containers, and labels containers/images with current plugin and driver keys. The app-side auth container client and session helpers send the new payload shape without accepting the old persona_id request field.

Validated with: pytest for the container image controller client, AI tool auth containers, and container image controller integration files; compileall for touched controller/app/contract/test modules; git diff --check; targeted cleanup search for removed tool-auth persona fields, env vars, labels, and probe keys in the edited boundary.
Update the AI harness runtime/status layer to project current plugin instance identity through auth runtime summaries, raw probe normalization, storage inventory, setup details, generic auth helpers, and system report rows. Runtime/status models now carry plugin_id, instance_id, and driver_id without a persona_id field, while later runner and review-policy persona cleanup remains explicitly scoped to follow-up plan steps.

Validated with: pytest for the AI tool instance suite, focused homepage runtime/status cases, the configured harness plugin catalog case, AI tool schema unit tests, compileall for the touched backend/test modules, git diff --check, and targeted persona cleanup searches.
jason-admin commented 2026-06-27 12:42:27 +00:00
Author
Owner
Copy link

CodeSnuffler Review Underway

Status: Review in progress

CodeSnuffler has started reviewing this pull request.

Field Value
Started at 2026-06-27T12:42:19.581983+00:00
Review ID forgejo-jason-admin-CodeSnuffler-FJ-pr-39
Review details Open review details
## CodeSnuffler Review Underway > **Status:** Review in progress > > CodeSnuffler has started reviewing this pull request. | Field | Value | | --- | --- | | Started at | `2026-06-27T12:42:19.581983+00:00` | | Review ID | `forgejo-jason-admin-CodeSnuffler-FJ-pr-39` | | Review details | [Open review details](https://ops.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-39) |
jason-admin closed this pull request 2026-06-27 12:44:58 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jason-admin/CodeSnuffler-FJ!39
No description provided.