CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260629T084251745Z-99530373-9b9 #43
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "change_forgejo_end_to_end"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.
Run marker: codesnuffler-forgejo-live-20260629T084251745Z-99530373-9b9.
Run started at: 2026-06-29T08:42:51.745Z.
Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This two-commit AI Harness range stops before
404b386cremoved stale persona and old-shape compatibility, so the review is expected to produce actionable findings.CodeSnuffler Review Findings
Findings
1. Tool auth probe receives the wrong profile shape
container_image_controller/api.py:977Details for this finding were posted as an inline review comment on the changed line.
Open finding in CodeSnuffler
Generate patch with CodeSnuffler
2. Persona compatibility alias remains in the instance model
app/ai_tools/instances.py:226-227The PR standardizes auth identity on
instance_id, butAiToolInstanceConfig.persona_idremains as a runtime alias and other code/tests still use it. The local AGENTS policy explicitly forbids compatibility shims when a field is standardized away, so this leaves the old shape live instead of removed.Open finding in CodeSnuffler
Generate patch with CodeSnuffler
Suggested fix: Remove the
persona_idproperty and replace remaining internal reads/tests withinstance_id; keep only rejection/absence tests for incomingpersona_idpayloads where useful.@ -949,3 +975,3 @@f"TOOL_AUTH_STORAGE_KEY={session.auth_storage_key}",f"TOOL_AUTH_HOST_PATH={host_dir}",f"TOOL_AUTH_PROFILE_JSON={json.dumps(profile.probe_config(), sort_keys=True, separators=(',', ':'))}",f"TOOL_AUTH_PROFILE_JSON={json.dumps(profile.controller_payload(), sort_keys=True, separators=(',', ':'))}",CodeSnuffler finding: Tool auth probe receives the wrong profile shape
Severity: High Category: Correctness
TOOL_AUTH_PROFILE_JSONis now populated withprofile.controller_payload(), but the embedded probe script still readsprofile["tool_container_paths"]andtool_container_mount_paths.controller_payload()exposespathsandmountsinstead, sostatus_payload()will raise a KeyError for every probe/API-key container run before returning JSON.Commit: Open commit
d8a3fc420b05Open finding in CodeSnuffler
Generate patch with CodeSnuffler
Suggested fix: Pass the probe-shaped payload here, or update
TOOL_PROBE_CODEto consume the controller payload shape consistently before switching the environment value.Pull request closed