CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260629T135441972Z-dc9a383d-5a0 #46

Closed

jason-admin wants to merge 2 commits from change_forgejo_end_to_end into base_forgejo_end_to_end

jason-admin commented

2026-06-29 13:55:38 +00:00

Owner

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.

Run marker: codesnuffler-forgejo-live-20260629T135441972Z-dc9a383d-5a0.
Run started at: 2026-06-29T13:54:41.972Z.

Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings.

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff. Run marker: codesnuffler-forgejo-live-20260629T135441972Z-dc9a383d-5a0. Run started at: 2026-06-29T13:54:41.972Z. Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1. This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings.

jason-admin added 2 commits

2026-06-29 13:55:38 +00:00

AI Harness: update tool auth contracts for plugin instances 11f109e6c2

This completes Step 12 of the AI harness plugin-instance plan by replacing the tool auth container session contract's persona field with explicit plugin instance identity. Controller request and response schemas, auth image refs, build payloads, dev-shell websocket forwarding, Docker labels, container env, and shared probe metadata now carry plugin_id, instance_id, and driver_id.

The controller now rejects mismatched plugin or driver identity, uses PLUGIN_INSTANCE_ID instead of TOOL_PERSONA_ID in auth containers, and labels containers/images with current plugin and driver keys. The app-side auth container client and session helpers send the new payload shape without accepting the old persona_id request field.

Validated with: pytest for the container image controller client, AI tool auth containers, and container image controller integration files; compileall for touched controller/app/contract/test modules; git diff --check; targeted cleanup search for removed tool-auth persona fields, env vars, labels, and probe keys in the edited boundary.

AI Harness: update runtime status projections for plugin instances d8a3fc420b

Update the AI harness runtime/status layer to project current plugin instance identity through auth runtime summaries, raw probe normalization, storage inventory, setup details, generic auth helpers, and system report rows. Runtime/status models now carry plugin_id, instance_id, and driver_id without a persona_id field, while later runner and review-policy persona cleanup remains explicitly scoped to follow-up plan steps.

Validated with: pytest for the AI tool instance suite, focused homepage runtime/status cases, the configured harness plugin catalog case, AI tool schema unit tests, compileall for the touched backend/test modules, git diff --check, and targeted persona cleanup searches.

jason-admin commented

2026-06-29 13:55:42 +00:00

Author

Owner

CodeSnuffler Review Findings

Recommendation	Risk	Open findings	Files touched by findings
Request Changes	Medium	1	1

Findings

1. Remove API-facing persona_id compatibility field

Severity	Category	Confidence	Location	Status
Medium	Maintainability	93%	`app/ai_tools/service.py:164`	Open

ConfiguredAiToolHarnessProfile still declares persona_id, and configured_ai_tool_harness_profiles() populates it from instance_id. This preserves the old identity shape in an API/service model while the PR is removing persona_id from tool auth contracts. Per the repository's no-compatibility-shims rule, remove this field and update downstream consumers/tests to use instance_id only.

Open finding in CodeSnuffler

Generate patch with CodeSnuffler

Suggested fix: Delete persona_id from ConfiguredAiToolHarnessProfile, remove the persona_id=instance_id construction, and update any ai-review-policy/harness consumers that still require persona_id to use instance_id.

![CodeSnuffler review banner](https://ops.codesnuffler.com/codesnuffler_review/assets/banner_mediumIssues) ## CodeSnuffler Review Findings | Recommendation | Risk | Open findings | Files touched by findings | | --- | --- | ---: | ---: | | Request Changes | Medium | 1 | 1 | ### Findings #### 1. Remove API-facing persona_id compatibility field | Severity | Category | Confidence | Location | Status | | --- | --- | ---: | --- | --- | | Medium | Maintainability | 93% | `app/ai_tools/service.py:164` | Open | `ConfiguredAiToolHarnessProfile` still declares `persona_id`, and `configured_ai_tool_harness_profiles()` populates it from `instance_id`. This preserves the old identity shape in an API/service model while the PR is removing `persona_id` from tool auth contracts. Per the repository's no-compatibility-shims rule, remove this field and update downstream consumers/tests to use `instance_id` only. [Open finding in CodeSnuffler](https://ops.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-46/findings/7) [Generate patch with CodeSnuffler](https://ops.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-46/findings/7/fix) **Suggested fix:** Delete `persona_id` from `ConfiguredAiToolHarnessProfile`, remove the `persona_id=instance_id` construction, and update any ai-review-policy/harness consumers that still require `persona_id` to use `instance_id`.

jason-admin closed this pull request

2026-06-29 13:57:41 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

jason-admin/CodeSnuffler-FJ!46

No description provided.

Rows
Columns