CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260630T050258359Z-db7a9e27-a1a #50

Closed

jason-admin wants to merge 2 commits from change_forgejo_end_to_end into base_forgejo_end_to_end

pull from: change_forgejo_end_to_end

merge into: jason-admin:base_forgejo_end_to_end

jason-admin:master

Conversation 1 Commits 2 Files changed 24 +408 -215

jason-admin commented 2026-06-30 05:04:06 +00:00

Owner

Copy link

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.

Run marker: codesnuffler-forgejo-live-20260630T050258359Z-db7a9e27-a1a.
Run started at: 2026-06-30T05:02:58.359Z.

Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings.

Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff. Run marker: codesnuffler-forgejo-live-20260630T050258359Z-db7a9e27-a1a. Run started at: 2026-06-30T05:02:58.359Z. Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1. This two-commit AI Harness range stops before 404b386c removed stale persona and old-shape compatibility, so the review is expected to produce actionable findings.

jason-admin added 2 commits 2026-06-30 05:04:06 +00:00

AI Harness: update tool auth contracts for plugin instances ... 11f109e6c2

This completes Step 12 of the AI harness plugin-instance plan by replacing the tool auth container session contract's persona field with explicit plugin instance identity. Controller request and response schemas, auth image refs, build payloads, dev-shell websocket forwarding, Docker labels, container env, and shared probe metadata now carry plugin_id, instance_id, and driver_id.

The controller now rejects mismatched plugin or driver identity, uses PLUGIN_INSTANCE_ID instead of TOOL_PERSONA_ID in auth containers, and labels containers/images with current plugin and driver keys. The app-side auth container client and session helpers send the new payload shape without accepting the old persona_id request field.

Validated with: pytest for the container image controller client, AI tool auth containers, and container image controller integration files; compileall for touched controller/app/contract/test modules; git diff --check; targeted cleanup search for removed tool-auth persona fields, env vars, labels, and probe keys in the edited boundary.

AI Harness: update runtime status projections for plugin instances ... d8a3fc420b

Update the AI harness runtime/status layer to project current plugin instance identity through auth runtime summaries, raw probe normalization, storage inventory, setup details, generic auth helpers, and system report rows. Runtime/status models now carry plugin_id, instance_id, and driver_id without a persona_id field, while later runner and review-policy persona cleanup remains explicitly scoped to follow-up plan steps.

Validated with: pytest for the AI tool instance suite, focused homepage runtime/status cases, the configured harness plugin catalog case, AI tool schema unit tests, compileall for the touched backend/test modules, git diff --check, and targeted persona cleanup searches.

jason-admin commented 2026-06-30 05:04:13 +00:00

Author

Owner

Copy link

CodeSnuffler Review Findings

Recommendation	Risk	Open findings	Files touched by findings
Request Changes	Medium	2	2

Findings

1. Dev shell login still sends removed persona_id parameter

Severity	Category	Confidence	Location	Status
Medium	Correctness	95%	frontend/src/dev-shell/components/DevShellTerminal.vue:154-155	Open

DevShellTerminal still accepts personaId and sends persona_id on the websocket URL, but app/dev_shell.py now reads only instance_id. Non-primary AI tool auth shell sessions launched from setup will silently fall back to primary instead of the selected plugin instance.

Open finding in CodeSnuffler

Fix via CodeSnuffler

Suggested fix: Rename the prop/callers to instanceId/:instance-id and send instance_id in the websocket query string.

2. Old persona-shaped contract remains exposed

Severity	Category	Confidence	Location	Status
Medium	Maintainability	90%	app/settings/ai_review_policy/schemas.py:72-77	Open

The PR removes persona_id from several auth container/controller contracts, but the AI review policy API still exposes persona_id, generated frontend types still contain it, and active code relies on the AiToolInstanceConfig.persona_id compatibility property. This violates the repository's no-compatibility-shims rule for removed/standardized fields and leaves old-shape naming in the public contract.

Open finding in CodeSnuffler

Fix via CodeSnuffler

Suggested fix: Replace this field with instance_id (and include plugin/driver identity if needed), regenerate frontend API types, update Vue callers, and remove the AiToolInstanceConfig.persona_id alias plus runtime uses of it.

 ## CodeSnuffler Review Findings | Recommendation | Risk | Open findings | Files touched by findings | | --- | --- | ---: | ---: | | Request Changes | Medium | 2 | 2 | ### Findings #### 1. Dev shell login still sends removed persona_id parameter | Severity | Category | Confidence | Location | Status | | --- | --- | ---: | --- | --- | | Medium | Correctness | 95% | `frontend/src/dev-shell/components/DevShellTerminal.vue:154-155` | Open | `DevShellTerminal` still accepts `personaId` and sends `persona_id` on the websocket URL, but `app/dev_shell.py` now reads only `instance_id`. Non-primary AI tool auth shell sessions launched from setup will silently fall back to `primary` instead of the selected plugin instance. [Open finding in CodeSnuffler](https://providers.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-50/findings/17) [Fix via CodeSnuffler](https://providers.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-50/findings/17/fix) **Suggested fix:** Rename the prop/callers to `instanceId`/`:instance-id` and send `instance_id` in the websocket query string. #### 2. Old persona-shaped contract remains exposed | Severity | Category | Confidence | Location | Status | | --- | --- | ---: | --- | --- | | Medium | Maintainability | 90% | `app/settings/ai_review_policy/schemas.py:72-77` | Open | The PR removes `persona_id` from several auth container/controller contracts, but the AI review policy API still exposes `persona_id`, generated frontend types still contain it, and active code relies on the `AiToolInstanceConfig.persona_id` compatibility property. This violates the repository's no-compatibility-shims rule for removed/standardized fields and leaves old-shape naming in the public contract. [Open finding in CodeSnuffler](https://providers.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-50/findings/18) [Fix via CodeSnuffler](https://providers.codesnuffler.com/codesnuffler_review/forgejo-jason-admin-CodeSnuffler-FJ-pr-50/findings/18/fix) **Suggested fix:** Replace this field with `instance_id` (and include plugin/driver identity if needed), regenerate frontend API types, update Vue callers, and remove the `AiToolInstanceConfig.persona_id` alias plus runtime uses of it.

jason-admin closed this pull request 2026-06-30 05:06:07 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

jason-admin/CodeSnuffler-FJ!50

No description provided.