CodeSnuffler Forgejo End-to-End historical review range codesnuffler-forgejo-live-20260710T163527207Z-013e73ad-d91 #53
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "change_forgejo_end_to_end"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Exercise the live Forgejo webhook review pipeline against a stable historical CodeSnuffler diff.
Run marker: codesnuffler-forgejo-live-20260710T163527207Z-013e73ad-d91.
Run started at: 2026-07-10T16:35:27.207Z.
Fixture range: f9d210eccd0075b6b39b606cea9b1376719aa062..d8a3fc420b055e04df1d203706b89b1f1261a9c1.
This stable two-commit AI Harness range is expected to produce actionable findings.
CodeSnuffler Review Findings
Findings
1. Dev shell auth login drops non-primary instance id
app/dev_shell.py:320Details for this finding were posted as an inline review comment on the changed line.
Open finding in CodeSnuffler
Fix via CodeSnuffler
@ -316,3 +318,3 @@async def dev_shell_websocket(websocket: WebSocket) -> None:command_id = websocket.query_params.get("command", "bash")persona_id = websocket.query_params.get("persona_id")instance_id = websocket.query_params.get("instance_id")CodeSnuffler finding: Dev shell auth login drops non-primary instance id
Severity: Medium Category: Correctness
dev_shell_websocketnow reads only theinstance_idquery parameter, butfrontend/src/dev-shell/components/DevShellTerminal.vuestill sendspersona_id. For runner auth commands launched from an AI tool setup flow with a non-primary instance, the backend will passNoneand_proxy_runner_auth_sessionwill fall back toprimary, so login/probe storage is written to the wrong plugin instance.Commit: Open commit
d8a3fc420b05Open finding in CodeSnuffler
Fix via CodeSnuffler
Suggested fix: Update the frontend dev-shell terminal contract to send
instance_id(and preferably rename the prop frompersonaIdtoinstanceId) so the websocket request matches the new backend API.Pull request closed